Issue 60 61#68
Conversation
micah-prime
commented
Jul 2, 2025
micah-prime
commented
- Scripts for add_pits_bulk_properties.py #60 and add_bsu_gpr.py #61
- Minor updates to the point data class to get these working
- Tests to verify the uploads work
* starting to make changes for insitupy >0.4 * Getting closer to having this running * I think my variable overrides logic isn't getting applied fully * Files parse, but I'm missing some columns * Point tests passing * I think this is just held up on merging the comments change now * insitupy version * Address PR comments * Doc string
|
FYI I added the fixes for the layer data tests with the new insitupy to this PR |
|
@micah-prime - Can you look into these conflicts and remaining open conversations? |
Also return a GeoDataframe to match method return signature.
Call to super did not change anything.
Conflicts: * snowex_db/point_data.py * snowex_db/point_primary_variable_overrides.yaml * snowex_db/upload/points.py
I have some time now and looking into pushing this PR over the finish line 🏁 |
Thanks @jomey, I won't have time to dive too much until next week. |
Removes the need to declare the constant already set in that super class
Instrument mapping was already done at the dataframe setup and allows to skip this step at the record creation point. Other changes combine multiple lines into one.
Row dictionary does not always have these present on the dataframe.
Only use the "name" attribute if it is explicitly passed as a kwarg. Otherwise use the PitID parsed from the row header.
|
Tests to be green locally for points and layers need this PR to be merged Note that I started a separate branch to fix raster tests. Generally, the tests don't pass for p 3.12 with an invalid import statement. Still need to have a look at that. We could also merge this as is and tackle a green CI in another PR. I vote to not use the 'squash merge' on this PR so we can better track commits later. |
|
@jomey this is on auto-merge now. I can't approve it since I opened it, but once you approve it will be merged! |
Have you had a chance to run the tests locally? |
|
@jomey I can confirm the tests all run locally, except for 10 errors all in the rasters folder. |
|
@aaarendt that's awesome! If you approve I should be able to get this merged in |
Rebase failed
3 participants
